-
Notifications
You must be signed in to change notification settings - Fork 12
Conversation
Also fix and update the other dependencies in the repository: 1) Use the latest revision of comptue API discovery (revision 2020/11/22) 2) Update to the lates gapic-generator (to fix `php_gapic_library` rule `transport` argument) 3) Update to the latest `gapic-generator-python` and `rules_python` (including changes in `WORKSPACE` file required by the newest version of rules_python).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please address the one comment about using a released Python version. Otherwise lgtm.
@@ -70,8 +71,8 @@ rules_proto_toolchains() | |||
# section |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the "common code" this comment refers to is only PHP? I do see a reference to py_gapic_repositories
in the rules below. Will we move that to the µgenerators?
@@ -235,8 +236,8 @@ pip_repositories() | |||
# Change upstream repository once PR is merged | |||
http_archive( | |||
name = "gapic_generator_python", | |||
strip_prefix = "gapic-generator-python-0.35.9", | |||
urls = ["https://github.com/googleapis/gapic-generator-python/archive/v0.35.9.zip"], | |||
strip_prefix = "gapic-generator-python-56c31de4a9f661e3d69b52e19c9a28dddfe9d7dc", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This SHA points to googleapis/gapic-generator-python#716, which has been committed. Let's point to the latest release, 0.39.1.
(see commit list)
|
||
// Specifies the maximum allowed TTL for cached content served by this origin. Cache directives that attempt to set a max-age or s-maxage higher than this, or an Expires header more than maxTTL seconds in the future will be capped at the value of maxTTL, as if it were the value of an s-maxage Cache-Control directive. Headers sent to the client will not be modified. Setting a TTL of "0" means "always revalidate". The maximum allowed value is 31,622,400s (1 year), noting that infrequently accessed objects may be evicted from the cache before the defined TTL. | ||
int32 max_ttl = 39142545; | ||
|
||
// Maximum number of seconds the response to a signed URL request will be considered fresh. After this time period, the response will be revalidated before being served. Defaults to 1hr (3600s). When serving responses to signed URL requests, Cloud CDN will internally behave as though all responses from this backend had a "Cache-Control: public, max-age=[TTL]" header, regardless of any existing Cache-Control header. The actual headers served in responses will not be altered. | ||
string signed_url_cache_max_age_sec = 939078; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hooray for deterministic field numbers!!!
Also fix and update the other dependencies in the repository:
Use the latest revision of comptue API discovery (revision 2020/11/22)
Update to the lates gapic-generator (to fix
php_gapic_library
ruletransport
argument)Update to the latest
gapic-generator-python
andrules_python
(including changes inWORKSPACE
file required by the newest version of rules_python).